Parse output from composer and list missing extensions #19
Conversation
AydinHassan
changed the title
Current coverage is 99.04% (diff: 96.52%)@@ master #19 diff @@
==========================================
Files 25 26 +1
Lines 649 735 +86
Methods 81 102 +21
Messages 0 0
Branches 0 0
==========================================
+ Hits 646 728 +82
- Misses 3 7 +4
Partials 0 0
|
|
Yo @mikeymike can you review please? |
| @@ -14,17 +14,23 @@ | |||
| */ | |||
| class ComposerInstallerFactoryTest extends PHPUnit_Framework_TestCase | |||
| { | |||
| public function testCreate() | |||
| public function testTrue() | |||
There was a problem hiding this comment.
mistake or coming back to it later?
There was a problem hiding this comment.
Yeah should be removed :D
| $this->assertFileExists(sprintf('%s/vendor', $this->tempDir)); | ||
| $this->assertFileExists(sprintf('%s/composer.lock', $this->tempDir)); | ||
|
|
||
| $expectedOutput = "/Loading composer repositories with package information\n"; |
There was a problem hiding this comment.
Just a thought... are we not making this a fragile test by testing the output of another package? I see why it's done I'm just wondering if it's the best thing to do.
Unfortunately I don't really have alternative other than checking that there was output which I guess in it self is a pretty weak/fragile test
There was a problem hiding this comment.
it has no requires and it's not a real package - so it should be fine imo
| @@ -14,40 +14,45 @@ | |||
| */ | |||
| class IOFactoryTest extends PHPUnit_Framework_TestCase | |||
There was a problem hiding this comment.
safe to remove this test right?
|
@AydinHassan nice stuff dude... I like the approach with the IO much cleaner 👍 |
| */ | ||
| public function __construct($exitCode, $output) | ||
| { | ||
| $this->exitCode = $exitCode; |
There was a problem hiding this comment.
nice find @scrutinizer-auto-fixer !
AydinHassan
force-pushed
the
improve-error-messages
branch
from
a947866 to
1ddddf2
Compare
TODO:
Fixes #18
Features:
composer.jsonso this can only be global installed if required ext's are there.