Skip to content

A safe space for nulls exercise #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 15, 2021
Merged

Conversation

AydinHassan
Copy link
Member

@AydinHassan AydinHassan commented Jun 11, 2021

@mikeymike please give the problem file a good once over, it's quite complicated I think

@AydinHassan AydinHassan changed the title Initial safe space for nulls exercise WIP: safe space for nulls exercise Jun 11, 2021
@AydinHassan AydinHassan changed the title WIP: safe space for nulls exercise A safe space for nulls exercise Jun 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2021

Codecov Report

Merging #23 (bcb330e) into master (197b24f) will increase coverage by 2.44%.
The diff coverage is 98.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #23      +/-   ##
============================================
+ Coverage     90.32%   92.76%   +2.44%     
- Complexity       90      120      +30     
============================================
  Files             6        7       +1     
  Lines           279      401     +122     
============================================
+ Hits            252      372     +120     
- Misses           27       29       +2     
Impacted Files Coverage Δ
src/Exercise/ASafeSpaceForNulls.php 98.36% <98.36%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 197b24f...bcb330e. Read the comment docs.

@mikeymike
Copy link
Member

@AydinHassan I think the problem file describes it very well without being overly waffly 😄

@AydinHassan AydinHassan force-pushed the a-safe-space-for-nulls branch from 740a871 to 0722d1a Compare June 12, 2021 16:13
@AydinHassan AydinHassan force-pushed the a-safe-space-for-nulls branch from bcb330e to 2fc1467 Compare June 15, 2021 21:21
@AydinHassan AydinHassan merged commit 8dd8a23 into master Jun 15, 2021
@AydinHassan AydinHassan deleted the a-safe-space-for-nulls branch June 15, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants