Skip to content

Lord of the strings #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 7, 2021
Merged

Lord of the strings #22

merged 9 commits into from
Jun 7, 2021

Conversation

AydinHassan
Copy link
Member

@AydinHassan AydinHassan commented Jun 6, 2021

@codecov-commenter
Copy link

Codecov Report

Merging #22 (8aca489) into master (493a567) will decrease coverage by 2.78%.
The diff coverage is 72.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #22      +/-   ##
============================================
- Coverage     91.57%   88.78%   -2.79%     
- Complexity       64       75      +11     
============================================
  Files             4        5       +1     
  Lines           190      223      +33     
============================================
+ Hits            174      198      +24     
- Misses           16       25       +9     
Impacted Files Coverage Δ
src/Exercise/LordOfTheStrings.php 72.72% <72.72%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 493a567...8aca489. Read the comment docs.

@AydinHassan AydinHassan marked this pull request as ready for review June 6, 2021 21:03
@AydinHassan AydinHassan requested a review from mikeymike June 6, 2021 21:03
@AydinHassan AydinHassan merged commit f0c39a8 into master Jun 7, 2021
@AydinHassan AydinHassan deleted the new-string-functions branch June 7, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants