Skip to content

Conversation

mikeymike
Copy link
Member

Implementation of Caution with Catches

Excercise required updates to workshop core to ensure solution files were patched etc. Now that's all merged this should be good 🤞

@mikeymike mikeymike requested a review from AydinHassan May 24, 2021 17:57
@codecov-commenter
Copy link

Codecov Report

Merging #19 (fbc67dd) into master (20204e5) will decrease coverage by 0.08%.
The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #19      +/-   ##
============================================
- Coverage     91.66%   91.57%   -0.09%     
- Complexity       54       64      +10     
============================================
  Files             3        4       +1     
  Lines           168      190      +22     
============================================
+ Hits            154      174      +20     
- Misses           14       16       +2     
Impacted Files Coverage Δ Complexity Δ
src/Exercise/CautionWithCatches.php 90.90% <90.90%> (ø) 10.00 <10.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20204e5...fbc67dd. Read the comment docs.

@AydinHassan
Copy link
Member

LGTM - Nice work!

@AydinHassan AydinHassan merged commit 4435bf4 into master May 25, 2021
@AydinHassan AydinHassan deleted the caution-with-catches branch May 25, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants