-
Notifications
You must be signed in to change notification settings - Fork 4
Add run command, refactor tests #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Current coverage is
|
darn it also dropped coverage 👎 |
hmmm just Travis |
@AydinHassan I can't re-create the test failing locally on any PHP version. Can you pull down and run them. On Travis 7.0 failed then after re-run 7.0 passed and 5.6 failed. Pretty sure it was on the same test too. |
/** | ||
* @param Request $request | ||
*/ | ||
public function writeRequest(Request $request); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should type hint the PSR RequestInterface
@AydinHassan I'll rebase before merge if all is good 👍 |
my bad didn't re-run the test 🐰 |
@mikeymike This ready? Can we squash it? |
Yeah can do, I did just realise I hadn't written a test for the RunCommand itself 😑 ... I can do this after the merge though, got nothing better to be doing 😆 What do you think ? |
Yeah, fine by me 😄 That's probably why the coverage went down! |
8be7307
to
b8db6b2
Compare
Add run command, refactor tests
Hoping this is all right, I was behind master so rebased but I had to manually resolve some conflicts. I think it's okay but could be wrong 😂
Also got to double check Travis tests