Skip to content

Fix CS for DockerProcessFactory #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2024
Merged

Fix CS for DockerProcessFactory #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Process/DockerProcessFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,12 @@ public function create(ProcessInput $processInput): Process
}, array_keys($processInput->getEnv()), $processInput->getEnv());

return new Process(
[...$this->baseComposeCommand($mounts, $env), 'runtime', $processInput->getExecutable(), ...$processInput->getArgs()],
[
...$this->baseComposeCommand($mounts, $env),
'runtime',
$processInput->getExecutable(),
...$processInput->getArgs()
],
$this->basePath,
['SOLUTION' => $processInput->getWorkingDirectory()],
$processInput->getInput(),
Expand Down
24 changes: 18 additions & 6 deletions test/Process/DockerProcessFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ public function testCreate(): void
$input = new ProcessInput('php', [], __DIR__, []);

$process = $factory->create($input);
static::assertSame("'/usr/local/bin/docker' 'compose' '-p' 'php8appreciate' '-f' '.docker/runtime/docker-compose.yml' 'run' '--rm' '-w' '/solution' 'runtime' 'php'", $process->getCommandLine());
$cmd = "'/usr/local/bin/docker' 'compose' '-p' 'php8appreciate' '-f' '.docker/runtime/docker-compose.yml'";
$cmd .= " 'run' '--rm' '-w' '/solution' 'runtime' 'php'";
static::assertSame($cmd, $process->getCommandLine());
static::assertSame('/docker-dir', $process->getWorkingDirectory());
}

Expand All @@ -54,7 +56,9 @@ public function testCreateMountsComposerCacheDirIfExecutableIsComposer(): void
$input = new ProcessInput('composer', [], __DIR__, []);

$process = $factory->create($input);
static::assertSame("'/usr/local/bin/docker' 'compose' '-p' 'php8appreciate' '-f' '.docker/runtime/docker-compose.yml' 'run' '--rm' '-w' '/solution' '-v' '/composer/cache/dir:/root/.composer/cache' 'runtime' 'composer'", $process->getCommandLine());
$cmd = "'/usr/local/bin/docker' 'compose' '-p' 'php8appreciate' '-f' '.docker/runtime/docker-compose.yml'";
$cmd .= " 'run' '--rm' '-w' '/solution' '-v' '/composer/cache/dir:/root/.composer/cache' 'runtime' 'composer'";
static::assertSame($cmd, $process->getCommandLine());
static::assertSame('/docker-dir', $process->getWorkingDirectory());
}

Expand All @@ -70,7 +74,9 @@ public function testCreateWithArgs(): void
$input = new ProcessInput('php', ['one', 'two'], __DIR__, []);

$process = $factory->create($input);
static::assertSame("'/usr/local/bin/docker' 'compose' '-p' 'php8appreciate' '-f' '.docker/runtime/docker-compose.yml' 'run' '--rm' '-w' '/solution' 'runtime' 'php' 'one' 'two'", $process->getCommandLine());
$cmd = "'/usr/local/bin/docker' 'compose' '-p' 'php8appreciate' '-f' '.docker/runtime/docker-compose.yml'";
$cmd .= "'run' '--rm' '-w' '/solution' 'runtime' 'php' 'one' 'two'";
static::assertSame($cmd, $process->getCommandLine());
static::assertSame('/docker-dir', $process->getWorkingDirectory());
}

Expand All @@ -86,7 +92,9 @@ public function testCreateWithEnv(): void
$input = new ProcessInput('php', ['one', 'two'], __DIR__, ['SOME_VAR' => 'value']);

$process = $factory->create($input);
static::assertSame("'/usr/local/bin/docker' 'compose' '-p' 'php8appreciate' '-f' '.docker/runtime/docker-compose.yml' 'run' '--rm' '-e SOME_VAR=value' '-w' '/solution' 'runtime' 'php' 'one' 'two'", $process->getCommandLine());
$cmd = "'/usr/local/bin/docker' 'compose' '-p' 'php8appreciate' '-f' '.docker/runtime/docker-compose.yml'";
$cmd .= " 'run' '--rm' '-e SOME_VAR=value' '-w' '/solution' 'runtime' 'php' 'one' 'two'";
static::assertSame($cmd, $process->getCommandLine());
static::assertSame('/docker-dir', $process->getWorkingDirectory());
}

Expand All @@ -102,7 +110,9 @@ public function testWithInput(): void
$input = new ProcessInput('php', [], __DIR__, [], 'someinput');

$process = $factory->create($input);
static::assertSame("'/usr/local/bin/docker' 'compose' '-p' 'php8appreciate' '-f' '.docker/runtime/docker-compose.yml' 'run' '--rm' '-w' '/solution' 'runtime' 'php'", $process->getCommandLine());
$cmd = "'/usr/local/bin/docker' 'compose' '-p' 'php8appreciate' '-f' '.docker/runtime/docker-compose.yml'";
$cmd .= " 'run' '--rm' '-w' '/solution' 'runtime' 'php'";
static::assertSame($cmd, $process->getCommandLine());
static::assertSame('someinput', $process->getInput());
}

Expand All @@ -118,7 +128,9 @@ public function testSolutionDirectoryIsPassedAsEnvVar(): void
$input = new ProcessInput('php', ['one', 'two'], __DIR__, ['SOME_VAR' => 'value']);

$process = $factory->create($input);
static::assertSame("'/usr/local/bin/docker' 'compose' '-p' 'php8appreciate' '-f' '.docker/runtime/docker-compose.yml' 'run' '--rm' '-e SOME_VAR=value' '-w' '/solution' 'runtime' 'php' 'one' 'two'", $process->getCommandLine());
$cmd = "'/usr/local/bin/docker' 'compose' '-p' 'php8appreciate' '-f' '.docker/runtime/docker-compose.yml'";
$cmd .= " 'run' '--rm' '-e SOME_VAR=value' '-w' '/solution' 'runtime' 'php' 'one' 'two'";
static::assertSame($cmd, $process->getCommandLine());
static::assertSame('/docker-dir', $process->getWorkingDirectory());
static::assertSame(['SOLUTION' => __DIR__], $process->getEnv());
}
Expand Down