Patch internal solution entrypoint files #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AydinHassan
reviewed
May 19, 2021
| $this->codePatcher->patch($event->getExercise(), $this->originalCode) | ||
| ); | ||
| foreach (array_filter($files) as $fileName) { | ||
| $this->originalCode[$fileName] = (string) file_get_contents($fileName); |
There was a problem hiding this comment.
Does it work if the files are the same name? I think it’s using full paths right so shouldn’t matter?
There was a problem hiding this comment.
Comes in as full paths from what I can see, so technically shouldn't matter 👍
|
The CS failure looks a little annoying tbh 😂 |
|
That is annoying, you can probably just ignore it in the config file if we have one |
I thought so too at first but we don't have the config setup atm, feels too much to add just for this. In all honesty, it just messes with the mock |
When patching a students given solution, we also need to patch our internal solution. This ensures that the comparison is like for like and the output solution would match what a student would have to provide
mikeymike
force-pushed
the
feature/patch-internal-solution-files
branch
from
57af5bd to
822e306
Compare
|
Hopefully fixed CS issue 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When patching a student's given solution, we also need to patch our internal solution.
This ensures that the comparison is like for like and the output solution would match what a student would have to provide.