Skip to content

File comparison check #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 12, 2021
Merged

File comparison check #202

merged 7 commits into from
Jun 12, 2021

Conversation

AydinHassan
Copy link
Member

This check allows us to compare "extra" file - for example if we ask the user to create an export file like users.csv

@AydinHassan AydinHassan force-pushed the file-comparison-check branch from 526b7bb to c4c5bc0 Compare February 7, 2021 20:18
@AydinHassan AydinHassan force-pushed the file-comparison-check branch from c4c5bc0 to a71b599 Compare April 21, 2021 13:45
@AydinHassan AydinHassan changed the title WIP: File comparison check File comparison check Apr 21, 2021
@AydinHassan AydinHassan closed this Jun 6, 2021
@AydinHassan AydinHassan reopened this Jun 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@cbf0f71). Click here to learn what that means.
The diff coverage is 83.58%.

❗ Current head 17a4756 differs from pull request most recent head 754617a. Consider uploading reports for the commit 754617a to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master     #202   +/-   ##
=========================================
  Coverage          ?   90.84%           
  Complexity        ?      710           
=========================================
  Files             ?      104           
  Lines             ?     2174           
  Branches          ?        0           
=========================================
  Hits              ?     1975           
  Misses            ?      199           
  Partials          ?        0           
Impacted Files Coverage Δ
src/Check/FileComparisonCheck.php 0.00% <0.00%> (ø)
src/Event/functions.php 100.00% <ø> (ø)
src/Exception/ProblemFileDoesNotExistException.php 0.00% <0.00%> (ø)
src/TestUtils/WorkshopExerciseTest.php 0.00% <0.00%> (ø)
src/WorkshopType.php 0.00% <0.00%> (ø)
src/functions.php 57.14% <0.00%> (ø)
src/Application.php 31.64% <37.03%> (ø)
src/Listener/CodePatchListener.php 88.23% <77.77%> (ø)
src/ComposerUtil/LockFileParser.php 93.33% <83.33%> (ø)
src/MenuItem/ResetProgress.php 92.30% <83.33%> (ø)
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbf0f71...754617a. Read the comment docs.

@AydinHassan AydinHassan force-pushed the file-comparison-check branch from a71b599 to 2f4487f Compare June 9, 2021 19:11
@AydinHassan AydinHassan requested a review from mikeymike June 9, 2021 19:13
@AydinHassan AydinHassan force-pushed the file-comparison-check branch 2 times, most recently from a973d1c to e4d54cf Compare June 12, 2021 09:08
@AydinHassan AydinHassan merged commit b5db77f into master Jun 12, 2021
@AydinHassan AydinHassan deleted the file-comparison-check branch June 12, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants