Skip to content

php-7.4 #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Oct 20, 2020
Merged

php-7.4 #164

merged 36 commits into from
Oct 20, 2020

Conversation

AydinHassan
Copy link
Member

No description provided.

@AydinHassan
php-7.4 test
2e73fa2
@AydinHassan
Drop php 7.1
bdde415
@AydinHassan
ignore phpunit cache
ed6580f
@AydinHassan
Add missing void hints
85eff2d
@AydinHassan
migrate phpunit config
0376399
@AydinHassan
Migrate to assertMatchesRegularExpression assertion
5ca26f1
@AydinHassan
Remove assertInternalType assertions
b2540dc
@AydinHassan
Use prophecy-phpunit
d3c6545
@AydinHassan
Fix readAttribute usages
6b8b9d1
@AydinHassan
Fix getChecksToRunAfter method to return correct checks
e810dce
@AydinHassan
Migrate to assertFileDoesNotExist assertion
6de3355
@AydinHassan
Use real eventdispatcher in tests
728681f
@AydinHassan
Fix at() usage
f162053
@AydinHassan
Use expectExceptionMessageMatches
b5b1643
@AydinHassan
Fix argument type
b5ab29b
@AydinHassan
Use asset interfaces
2172696
@AydinHassan
Fix exception assertions
5b2f109
@AydinHassan
Adapt regexes for 7.4
d7df123
@AydinHassan
CS
d066044
@AydinHassan
Remove phpspec/prophecy-phpunit on 7.2
534bf63
@AydinHassan
try again
ca5d40a
@AydinHassan
fix remove
c47601f
@AydinHassan
Try with GH actions
ff76376
@AydinHassan
Fix 7.2 version
86f3eb9
@AydinHassan
Try again
4fe9b3d
@AydinHassan
Add php version
6b5d2d9
@AydinHassan
No update on remove
1d0135f
@AydinHassan
Remove trait on 7.2
b665d8d
@AydinHassan
Use symfony/phpunit-bridge
4b55164
@AydinHassan
Update install of install
e9a8e82
@codecov-io
Copy link

Codecov Report

Merging #164 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #164      +/-   ##
============================================
- Coverage     95.62%   95.60%   -0.02%     
- Complexity      608      611       +3     
============================================
  Files            94       94              
  Lines          1918     1912       -6     
============================================
- Hits           1834     1828       -6     
  Misses           84       84
Impacted Files Coverage Δ Complexity Δ
src/Check/PhpLintCheck.php 100.00% <100.00%> (ø) 6.00 <0.00> (ø)
src/Event/EventDispatcher.php 100.00% <100.00%> (ø) 12.00 <11.00> (+1.00)
src/Exercise/TemporaryDirectoryTrait.php 100.00% <100.00%> (ø) 1.00 <1.00> (ø)
src/ExerciseDispatcher.php 100.00% <100.00%> (ø) 20.00 <2.00> (+2.00)
src/ExerciseRunner/CgiRunner.php 90.74% <100.00%> (ø) 25.00 <0.00> (ø)
src/ExerciseRunner/CliRunner.php 98.75% <100.00%> (+0.06%) 20.00 <0.00> (ø)
src/Factory/MenuFactory.php 81.69% <100.00%> (ø) 11.00 <0.00> (ø)
src/Listener/PrepareSolutionListener.php 100.00% <100.00%> (ø) 7.00 <0.00> (ø)
src/Solution/SingleFileSolution.php 100.00% <100.00%> (ø) 6.00 <1.00> (ø)
src/Exception/InvalidArgumentException.php 96.15% <0.00%> (-0.40%) 10.00% <0.00%> (ø%)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eafddcb...9362a59. Read the comment docs.

@AydinHassan AydinHassan merged commit a9525f1 into master Oct 20, 2020
@AydinHassan AydinHassan deleted the php-74 branch October 20, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AydinHassan @codecov-io