Skip to content

php-7.4 #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Oct 20, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
2e73fa2
php-7.4 test
AydinHassan Oct 20, 2020
bdde415
Drop php 7.1
AydinHassan Oct 20, 2020
ed6580f
ignore phpunit cache
AydinHassan Oct 20, 2020
85eff2d
Add missing void hints
AydinHassan Oct 20, 2020
0376399
migrate phpunit config
AydinHassan Oct 20, 2020
5ca26f1
Migrate to assertMatchesRegularExpression assertion
AydinHassan Oct 20, 2020
b2540dc
Remove assertInternalType assertions
AydinHassan Oct 20, 2020
d3c6545
Use prophecy-phpunit
AydinHassan Oct 20, 2020
6b8b9d1
Fix readAttribute usages
AydinHassan Oct 20, 2020
e810dce
Fix getChecksToRunAfter method to return correct checks
AydinHassan Oct 20, 2020
6de3355
Migrate to assertFileDoesNotExist assertion
AydinHassan Oct 20, 2020
728681f
Use real eventdispatcher in tests
AydinHassan Oct 20, 2020
f162053
Fix at() usage
AydinHassan Oct 20, 2020
b5b1643
Use expectExceptionMessageMatches
AydinHassan Oct 20, 2020
b5ab29b
Fix argument type
AydinHassan Oct 20, 2020
2172696
Use asset interfaces
AydinHassan Oct 20, 2020
5b2f109
Fix exception assertions
AydinHassan Oct 20, 2020
d7df123
Adapt regexes for 7.4
AydinHassan Oct 20, 2020
d066044
CS
AydinHassan Oct 20, 2020
534bf63
Remove phpspec/prophecy-phpunit on 7.2
AydinHassan Oct 20, 2020
ca5d40a
try again
AydinHassan Oct 20, 2020
c47601f
fix remove
AydinHassan Oct 20, 2020
ff76376
Try with GH actions
AydinHassan Oct 20, 2020
86f3eb9
Fix 7.2 version
AydinHassan Oct 20, 2020
4fe9b3d
Try again
AydinHassan Oct 20, 2020
6b5d2d9
Add php version
AydinHassan Oct 20, 2020
1d0135f
No update on remove
AydinHassan Oct 20, 2020
b665d8d
Remove trait on 7.2
AydinHassan Oct 20, 2020
4b55164
Use symfony/phpunit-bridge
AydinHassan Oct 20, 2020
e9a8e82
Update install of install
AydinHassan Oct 20, 2020
b3f09ec
fix binary name
AydinHassan Oct 20, 2020
b4b1097
Use terminal from container
AydinHassan Oct 20, 2020
d8d107e
Use error output only for linting
AydinHassan Oct 20, 2020
10d4272
Fix failure regex
AydinHassan Oct 20, 2020
0e22bfa
Remove fast fail
AydinHassan Oct 20, 2020
9362a59
Remove travis
AydinHassan Oct 20, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions .github/workflows/php-workshop.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
name: PhpWorkshop

on:
push:
branches: [ master ]
pull_request:
branches: [ master ]

jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
php: [7.2, 7.3, 7.4]

name: PHP ${{ matrix.php }}
steps:
- name: Checkout
uses: actions/checkout@v2

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
tools: composer:v2

- name: Install Dependencies
run: composer update --prefer-dist

- name: Run phpunit tests
run: |
mkdir -p build/logs
vendor/bin/simple-phpunit --coverage-clover ./build/logs/clover.xml

- name: Run phpcs
run: composer cs

# - name: Run phpstan
# run: composer static

- name: Coverage upload
if: matrix.php == '7.4'
run: bash <(curl -s https://codecov.io/bash)

4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
/vendor
/.idea
program.php
program.php
.phpunit.result.cache
/build
25 changes: 0 additions & 25 deletions .travis.yml

This file was deleted.

6 changes: 3 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
}
],
"require" : {
"php" : ">=7.1",
"php" : ">=7.2",
"ext-pdo_sqlite": "*",
"php-di/php-di": "^6.0",
"container-interop/container-interop": "^1.0",
Expand All @@ -33,8 +33,8 @@
},
"require-dev": {
"composer/composer": "^1.2",
"phpunit/phpunit": "^7",
"squizlabs/php_codesniffer": "^3.4"
"squizlabs/php_codesniffer": "^3.4",
"symfony/phpunit-bridge": "^5.1"
},
"autoload" : {
"psr-4" : {
Expand Down
Loading