Skip to content

Register event listeners via config #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2016

Conversation

AydinHassan
Copy link
Member

@AydinHassan AydinHassan commented Oct 31, 2016

This is a much more flexible, BC feature to achieve the same as #130.

@codecov-io
Copy link

codecov-io commented Oct 31, 2016

Current coverage is 89.93% (diff: 97.29%)

Merging #133 into master will increase coverage by 1.40%

@@             master       #133   diff @@
==========================================
  Files            70         70          
  Lines          1569       1590    +21   
  Methods         284        286     +2   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1389       1430    +41   
+ Misses          180        160    -20   
  Partials          0          0          

Powered by Codecov. Last update 602dc82...71bc53a

Copy link
Member

@mikeymike mikeymike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikeymike mikeymike merged commit 79aef98 into master Nov 1, 2016
@mikeymike mikeymike deleted the register-event-listeners-via-config branch November 1, 2016 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants