Skip to content

Add a call to onSelected() when an exercise is selected from the menu #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

AydinHassan
Copy link
Member

@AydinHassan AydinHassan commented Oct 26, 2016

This is a BC break, hence targeting develop, it adds another method to ExerciseInterface, named onSelect which is invoked when an exercise is selected from the menu.

Partially fixes php-school/learn-you-php#67

@codecov-io
Copy link

codecov-io commented Oct 26, 2016

Current coverage is 88.53% (diff: 40.00%)

Merging #130 into develop will decrease coverage by 0.16%

@@            develop       #130   diff @@
==========================================
  Files            70         70          
  Lines          1593       1596     +3   
  Methods         292        293     +1   
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1413       1413          
- Misses          180        183     +3   
  Partials          0          0          

Powered by Codecov. Last update 2ddd156...d2750cc

@AydinHassan AydinHassan closed this Nov 2, 2016
@AydinHassan AydinHassan deleted the hooks-for-selecting-exercises branch November 2, 2016 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants