Skip to content

PHP 8.3 Deprecation Notices #25

@chasebolt

Description

@chasebolt

Bug Description

When passing the --exclude flag, it outputs deprecation notices.

# var-dump-check --version
0.5
# var-dump-check --laravel --exclude vendor .

Deprecated: Return type of JakubOnderka\PhpVarDumpCheck\RecursiveDirectoryFilterIterator::hasChildren() should either be compatible with RecursiveFilterIterator::hasChildren(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /tools/php-parallel-lint/php-var-dump-check/vendor/php-parallel-lint/php-var-dump-check/src/RecursiveDirectoryFilterIterator.php on line 49

Call Stack:
    0.0035     473056   1. {main}() /tools/php-parallel-lint/php-var-dump-check/vendor/php-parallel-lint/php-var-dump-check/var-dump-check:0
    0.0115     568304   2. require('/tools/php-parallel-lint/php-var-dump-check/vendor/php-parallel-lint/php-var-dump-check/var-dump-check.php') /tools/php-parallel-lint/php-var-dump-check/vendor/php-parallel-lint/php-var-dump-check/var-dump-check:4
    0.0296     677176   3. JakubOnderka\PhpVarDumpCheck\Manager->check($settings = class JakubOnderka\PhpVarDumpCheck\Settings { public $extensions = [0 => 'php', 1 => 'php3', 2 => 'php4', 3 => 'php5', 4 => 'phtml']; public $paths = [0 => '.']; public $excluded = [0 => 'vendor']; public $colors = TRUE; public $functionsToCheck = [0 => 'var_dump', 1 => 'var_export', 2 => 'print_r', 3 => 'dd', 4 => 'dump'] }, $output = ???) /tools/php-parallel-lint/php-var-dump-check/vendor/php-parallel-lint/php-var-dump-check/var-dump-check.php:86
    0.0296     677176   4. JakubOnderka\PhpVarDumpCheck\Manager->getFilesFromPaths($paths = [0 => '.'], $extensions = [0 => 'php', 1 => 'php3', 2 => 'php4', 3 => 'php5', 4 => 'phtml'], $excluded = [0 => 'vendor']) /tools/php-parallel-lint/php-var-dump-check/vendor/php-parallel-lint/php-var-dump-check/src/Manager.php:14
    0.0306     686000   5. Composer\Autoload\ClassLoader->loadClass($class = 'JakubOnderka\\PhpVarDumpCheck\\RecursiveDirectoryFilterIterator') /tools/php-parallel-lint/php-var-dump-check/vendor/php-parallel-lint/php-var-dump-check/src/Manager.php:135
    0.0307     686192   6. Composer\Autoload\{closure:/tools/php-parallel-lint/php-var-dump-check/vendor/composer/ClassLoader.php:575-577}($file = '/tools/php-parallel-lint/php-var-dump-check/vendor/composer/../php-parallel-lint/php-var-dump-check/src/RecursiveDirectoryFilterIterator.php') /tools/php-parallel-lint/php-var-dump-check/vendor/composer/ClassLoader.php:427


Deprecated: Return type of JakubOnderka\PhpVarDumpCheck\RecursiveDirectoryFilterIterator::getChildren() should either be compatible with RecursiveFilterIterator::getChildren(): ?RecursiveFilterIterator, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /tools/php-parallel-lint/php-var-dump-check/vendor/php-parallel-lint/php-var-dump-check/src/RecursiveDirectoryFilterIterator.php on line 61

Call Stack:
    0.0035     473056   1. {main}() /tools/php-parallel-lint/php-var-dump-check/vendor/php-parallel-lint/php-var-dump-check/var-dump-check:0
    0.0115     568304   2. require('/tools/php-parallel-lint/php-var-dump-check/vendor/php-parallel-lint/php-var-dump-check/var-dump-check.php') /tools/php-parallel-lint/php-var-dump-check/vendor/php-parallel-lint/php-var-dump-check/var-dump-check:4
    0.0296     677176   3. JakubOnderka\PhpVarDumpCheck\Manager->check($settings = class JakubOnderka\PhpVarDumpCheck\Settings { public $extensions = [0 => 'php', 1 => 'php3', 2 => 'php4', 3 => 'php5', 4 => 'phtml']; public $paths = [0 => '.']; public $excluded = [0 => 'vendor']; public $colors = TRUE; public $functionsToCheck = [0 => 'var_dump', 1 => 'var_export', 2 => 'print_r', 3 => 'dd', 4 => 'dump'] }, $output = ???) /tools/php-parallel-lint/php-var-dump-check/vendor/php-parallel-lint/php-var-dump-check/var-dump-check.php:86
    0.0296     677176   4. JakubOnderka\PhpVarDumpCheck\Manager->getFilesFromPaths($paths = [0 => '.'], $extensions = [0 => 'php', 1 => 'php3', 2 => 'php4', 3 => 'php5', 4 => 'phtml'], $excluded = [0 => 'vendor']) /tools/php-parallel-lint/php-var-dump-check/vendor/php-parallel-lint/php-var-dump-check/src/Manager.php:14
    0.0306     686000   5. Composer\Autoload\ClassLoader->loadClass($class = 'JakubOnderka\\PhpVarDumpCheck\\RecursiveDirectoryFilterIterator') /tools/php-parallel-lint/php-var-dump-check/vendor/php-parallel-lint/php-var-dump-check/src/Manager.php:135
    0.0307     686192   6. Composer\Autoload\{closure:/tools/php-parallel-lint/php-var-dump-check/vendor/composer/ClassLoader.php:575-577}($file = '/tools/php-parallel-lint/php-var-dump-check/vendor/composer/../php-parallel-lint/php-var-dump-check/src/RecursiveDirectoryFilterIterator.php') /tools/php-parallel-lint/php-var-dump-check/vendor/composer/ClassLoader.php:427


Deprecated: Return type of JakubOnderka\PhpVarDumpCheck\RecursiveDirectoryFilterIterator::accept() should either be compatible with FilterIterator::accept(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /tools/php-parallel-lint/php-var-dump-check/vendor/php-parallel-lint/php-var-dump-check/src/RecursiveDirectoryFilterIterator.php on line 30

Call Stack:
    0.0035     473056   1. {main}() /tools/php-parallel-lint/php-var-dump-check/vendor/php-parallel-lint/php-var-dump-check/var-dump-check:0
    0.0115     568304   2. require('/tools/php-parallel-lint/php-var-dump-check/vendor/php-parallel-lint/php-var-dump-check/var-dump-check.php') /tools/php-parallel-lint/php-var-dump-check/vendor/php-parallel-lint/php-var-dump-check/var-dump-check:4
    0.0296     677176   3. JakubOnderka\PhpVarDumpCheck\Manager->check($settings = class JakubOnderka\PhpVarDumpCheck\Settings { public $extensions = [0 => 'php', 1 => 'php3', 2 => 'php4', 3 => 'php5', 4 => 'phtml']; public $paths = [0 => '.']; public $excluded = [0 => 'vendor']; public $colors = TRUE; public $functionsToCheck = [0 => 'var_dump', 1 => 'var_export', 2 => 'print_r', 3 => 'dd', 4 => 'dump'] }, $output = ???) /tools/php-parallel-lint/php-var-dump-check/vendor/php-parallel-lint/php-var-dump-check/var-dump-check.php:86
    0.0296     677176   4. JakubOnderka\PhpVarDumpCheck\Manager->getFilesFromPaths($paths = [0 => '.'], $extensions = [0 => 'php', 1 => 'php3', 2 => 'php4', 3 => 'php5', 4 => 'phtml'], $excluded = [0 => 'vendor']) /tools/php-parallel-lint/php-var-dump-check/vendor/php-parallel-lint/php-var-dump-check/src/Manager.php:14
    0.0306     686000   5. Composer\Autoload\ClassLoader->loadClass($class = 'JakubOnderka\\PhpVarDumpCheck\\RecursiveDirectoryFilterIterator') /tools/php-parallel-lint/php-var-dump-check/vendor/php-parallel-lint/php-var-dump-check/src/Manager.php:135
    0.0307     686192   6. Composer\Autoload\{closure:/tools/php-parallel-lint/php-var-dump-check/vendor/composer/ClassLoader.php:575-577}($file = '/tools/php-parallel-lint/php-var-dump-check/vendor/composer/../php-parallel-lint/php-var-dump-check/src/RecursiveDirectoryFilterIterator.php') /tools/php-parallel-lint/php-var-dump-check/vendor/composer/ClassLoader.php:427

I'd expect the following behaviour

No deprecation notices

Instead this happened

Environment

Version: 0.5

Additional Context (optional)

Tested Against main branch?

  • I have verified the issue still exists in the main branch of this package.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions