-
Notifications
You must be signed in to change notification settings - Fork 25
Implement faster FilteredRecursiveDirectoryIterator #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jrfnl anything I can do to move this forward? |
|
@staabm Not really. I'll try to find some time to review this over the next few weeks. That should hopefully help, but this is, in my experience, generally speaking a slow moving repo, so patience is the keyword... |
|
Tbh I have implemented against 1.x - we need to verify it against 2.x (and see whether the speed improvements are still visible on 2.x) |
|
let my clarify my last comment: the PR works in parallel-lint 1.x which I am currently using and it gives a decent speed boost, because without it, I did not verify the fix on parallel-int 2.x .. it looks like on 2.x the vendor is properly ignored even before this patch |
|
@jrfnl we just talked about this :-) (It might no longer be relevant) |
fix cs use ReturnTypeWillChange Removed debug out Typo
cafe817 to
b53b3b3
Compare
|
I can no longer reproduce the slownes in the latest 1.4.x release |
closes #135
running parallel lint in https://github.com/FriendsOfREDAXO/rexstan with
vendor/bin/parallel-lint . --exclude vendortakes0.3 secondswith this PR while it took9 secondsbefore the PR