Skip to content

Composer: allow for the 1.0.0 version of the Composer PHPCS plugin #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Jan 5, 2023

The Composer PHPCS plugin has released its 1.0.0 version. 🎉

Important:
I've widened the version constraints for the plugin, instead of bumping it.

The reason for this is to prevent conflicts with end-user projects/other external PHPCS standards which may also require(-dev) the plugin, but may not (yet) have updated their constraints for the plugin. If the version would have been bumped instead of widened, those users would get an unsolvable conflict during the composer install run (unless they require-dev the plugin for the root project, but then, that's exactly what we don't want them to do as external standards managing the versions of the plugins should be more reliable).

Ref: https://github.com/PHPCSStandards/composer-installer/releases/tag/v1.0.0

The Composer PHPCS plugin has released its 1.0.0 version. 🎉

Important:
I've _widened_ the version constraints for the plugin, instead of _bumping_ it.

The reason for this is to prevent conflicts with end-user projects/other external PHPCS standards which may also require(-dev) the plugin, but may not (yet) have updated _their_ constraints for the plugin.
If the version would have been bumped instead of widened, those users would get an unsolvable conflict during the `composer install` run (unless they `require-dev` the plugin for the root project, but then, that's exactly what we _don't_ want them to do as external standards managing the versions of the plugins should  be more reliable).

Ref: https://github.com/PHPCSStandards/composer-installer/releases/tag/v1.0.0
@jrfnl jrfnl added this to the 2.x Next milestone Jan 5, 2023
@grogy grogy merged commit 864ec19 into master May 25, 2023
@grogy grogy deleted the feature/update-for-1.0-release-of-composer-phpcs-plugin branch May 25, 2023 19:56
@grogy
Copy link
Member

grogy commented May 25, 2023

Thank you, widened versions is good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants