Fixes PHPUnit 8.4 compatibility #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalbundyra
approved these changes
Oct 5, 2019
Member
michalbundyra
left a comment
michalbundyra
left a comment
There was a problem hiding this comment.
@MasterOdin this looks awesome. 👍 Thanks a lot for your effort!
I am going to release it soon.
michalbundyra
added a commit
that referenced
this pull request
Oct 5, 2019
Fixes PHPUnit 8.4 compatibility
Member
|
Thanks, @MasterOdin! |
Contributor
Author
|
No problem, this is a really indispensable piece of kit for unit testing without having to build endless abstractions! |
Contributor
Author
|
As a follow-up, with the release of PHPUnit 8.4.1 today, all unit tests pass without issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39
Fixes things to run under PHPUnit 8.4 with all tests passing with the exception of a warning on
phpmock\phpunit\PHPMockTest::testBackupStaticAttributesdue to sebastianbergmann/phpunit#3879.I've extended Travis-CI to test against PHPUnit 8.3 and 8.4 as well.