This repository was archived by the owner on Jul 16, 2025. It is now read-only.
chore: Allow arbitrary vector dimensions for MariaDB store #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
added a commit
to symfony/ai
that referenced
this pull request
Jul 1, 2025
…(valtzu) This PR was merged into the main branch. Discussion ---------- chore: Allow arbitrary vector dimensions for MariaDB store | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Docs? | | Issues | | License | MIT Cherry picking php-llm/llm-chain#348 > MariaDB insists the dimensions of the vector being inserted match exactly the dimensions of the vector defined in the schema. Since the store knows nothing about the Model & it's expected vector dimensions, let's allow passing vector dimensions as a parameter to `initialize()` leave the problem to the user. Commits ------- b1c2fe5 chore: Allow arbitrary vector dimensions for MariaDB store (#348)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MariaDB insists the dimensions of the vector being inserted match exactly the dimensions of the vector defined in the schema.
Since the store knows nothing about the Model & it's expected vector dimensions, let's allow passing vector dimensions as a parameter to
initialize()leave the problem to the user.