Skip to content

Bug/curl fromater fails #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 9, 2018
Merged

Bug/curl fromater fails #94

Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bf24ed7
Added check escapeshellarg with data
llaakkkk Mar 7, 2018
ad715e4
Added check escapeshellarg with data
llaakkkk Mar 7, 2018
05707e8
Fixed uses
llaakkkk Mar 7, 2018
4277f6e
Fixed code format
llaakkkk Mar 7, 2018
1fea056
Fixed code format
llaakkkk Mar 7, 2018
47585f0
Fixed code format
llaakkkk Mar 7, 2018
4e8b8ce
Added die when
llaakkkk Mar 7, 2018
15fa062
Fixed code format
llaakkkk Mar 7, 2018
0fe86ee
Fixed silently suppress error
llaakkkk Mar 7, 2018
ac5ed42
Fixed silently suppress error code readable
llaakkkk Jun 6, 2018
157d67d
Fixed formatting
llaakkkk Jun 6, 2018
fd0c797
Fixed foramting
llaakkkk Jun 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Formatter/CurlCommandFormatter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,12 @@ public function formatRequest(RequestInterface $request)
} else {
$data = '[non-seekable stream omitted]';
}
$command .= sprintf(' --data %s', escapeshellarg($data));

$escapedData = @escapeshellarg($data);
if (isset($php_errormsg)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this always be false? Nothing defines $php_errormsg, right?

throw new \InvalidArgumentException($php_errormsg);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not want any exceptions or errors here. We want to silently fail. If we want to be extra nice to the user we may include a error message in the command.

// if fail:
$escapedData = 'We cound not escape the data properly';

}
$command .= sprintf(' --data %s', $escapedData);
}

return $command;
Expand Down