Adding PSR package #128

Nyholm · 2017-08-18T12:38:57Z

Yes, This PR is very premature. I just want to make sure we all agree (and look forward to) that this is eventually going to be merged.

This will fix #51

Nyholm · 2018-07-23T20:32:31Z

src/HttpAsyncClient.php

@@ -23,5 +23,5 @@
     *
     * @throws \Exception If processing the request is impossible (eg. bad configuration).
     */
-    public function sendAsyncRequest(RequestInterface $request);
+    public function sendAsyncRequest(RequestInterface $request): Promise;


Is this problem when we are doing the same update for the Async HTTP client PSR?

there needs to be a new major version anyways when a promise PSR is out, so we might as well do this change now to make it more explicit.

I would like to be more permissive in the async implementation, to allow every value and exception in our promise, this would be better, after years of use it was a mistake to reduce the scope IMO.

Fair, so what do you suggest? I've written Promise here, not HttpPromise.

In fact, it's in another package, we would need to update the promise lib and then allow 2.0 here, but maybe it will not be bc break for this package, so nothing to change here

(We would still need to release a 2.1 with the package dependency upgrade to allow 1.0 || 2.0 for the promise lib)

In fact what do you think of using https://amphp.org/amp/promises/ interface ? there is an adapter for react and we could drop support of async for guzzle (as it's not really async in fact, it's only parallel)

Hm.. Im not sure at all...

On one hand: Do as little change as possible. That will make it easier for everyone.
On the other hand: Can we make the "correct" decision now so there is no need for v3 when we got a PSR for Promise...? Probably not, right?

how soon is a PSR Promise to be expected? i would assume that will take a couple of years, so if its a clear and good upgrade, i would be ok to have version 2 do something different. then again, to make the PSR move for sync http client as smooth as possible, its maybe better to not limit ourselves here and avoid a BC break

dbu · 2018-07-24T07:17:28Z

src/Exception/HttpException.php

@@ -42,7 +42,7 @@ public function __construct(
     *
     * @return ResponseInterface


in our projects we started the rule that when @return just repeats the return type declaration and has no valuable information, we remove the @return line.

(in that vein "Returns the response" is redundant to the method name. either there is more details to explain or there should be no comment...)

I agree. 👍

I will remove these redundant comments.

Nyholm · 2018-07-24T20:13:41Z

src/Exception/HttpException.php

-     * @return ResponseInterface
-     */
-    public function getResponse()
+    public function getResponse(): ResponseInterface


This is a BC break: https://3v4l.org/LOOiv

Is this something we want to avoid in this update to make it as smooth as possible?

Nyholm · 2018-07-24T20:16:03Z

src/Exception/HttpException.php

     */
    public static function create(
        RequestInterface $request,
        ResponseInterface $response,
        \Exception $previous = null
-    ) {
+    ): self {


Nyholm · 2018-07-29T02:26:19Z

Im done with this PR. I suggest merging it now and start prepare for a 2.0 release.

Releasing 2.0 is obviously blocked by a stable release of psr/http-client

Nyholm · 2018-07-29T02:32:59Z

I removed HHVM because it failed because of a PHPSpec error (I think) https://travis-ci.org/php-http/httplug/jobs/409431649

dbu

this looks great! so indeed the transition path looks quite sane.

as for merging, i guess as long as we don't release a version, we should be fine even if it turns out that PSR-18 still changes somehow.

please adjust the branch-alias in composer.json to 2.0-dev

dbu · 2018-07-30T06:46:51Z

CHANGELOG.md

@@ -1,5 +1,24 @@
 # Change Log

+## 2.0.0 - UNRELEASED
+
+This version contains is technically a BC break because we drop PHP5 and add return 


dropping PHP5 support is no BC break. it just prevents people on an obsolete stack from updating

how do you mean "technically"? i think we should say: "This version is no BC break for consumers using HTTPlug. However, HTTP clients that implement HTTPlug need to adjust because we add return type declarations."

dbu · 2018-07-30T06:47:25Z

CHANGELOG.md

+
+### Added
+
+- Support for PSR-18 (Http client).


Http or HTTP? (i don't really care but we should be consistent in our doc and consistent with how fig documents write it)

dbu · 2018-07-30T06:47:43Z

CHANGELOG.md

+
+### Changed
+
+- [BC Break] `HttpClient::sendRequest(RequestInterface $request)` has a return type annotation. The mew 


s/mew/new/ ;-)

Nyholm · 2018-07-30T07:08:19Z

Thank you for the review. I've corrected the PR accordingly.

dbu

great, happy with it like this!

i'll wait a bit if @sagikazarmark has input as well

sagikazarmark · 2018-07-30T08:20:32Z

Looks good to me. 👍

Nyholm · 2018-07-30T08:36:11Z

I've changed base to a new 2.x branch.

Nyholm · 2018-07-30T08:36:35Z

Thank you for the reviews.

Adding PSR package

af00486

Nyholm force-pushed the psr-http-client branch from fd0fb11 to af00486 Compare August 19, 2017 07:33

Added return types and dropped PHP5

cbc903a

Nyholm commented Jul 23, 2018

View reviewed changes

dbu reviewed Jul 24, 2018

View reviewed changes

Removed redundant comments

de1c010

Nyholm commented Jul 24, 2018

View reviewed changes

Nyholm added 6 commits July 24, 2018 13:20

Removed return type

307c7fe

Removed return types

58d0ada

Make sure our exception implements the correct interfaces

7d9f4ec

Make it more clear what interface we are implementing

f217324

minor

310b13f

Use version 0.1

b45b737

Remove HHVM

f5b7e91

Added change log

b1f4ee6

dbu requested changes Jul 30, 2018

View reviewed changes

Nyholm added 2 commits July 30, 2018 00:07

Small fixes

1b29077

Updated branch alias

b16582b

dbu approved these changes Jul 30, 2018

View reviewed changes

sagikazarmark approved these changes Jul 30, 2018

View reviewed changes

Nyholm changed the base branch from master to 2.x July 30, 2018 08:35

Nyholm merged commit 6885b6c into 2.x Jul 30, 2018

Nyholm deleted the psr-http-client branch July 30, 2018 08:36

Nyholm pushed a commit to Nyholm/httplug that referenced this pull request Dec 26, 2019

rewrite all profiler logic (php-http#128)

a0f42af

		@@ -42,7 +42,7 @@ public function __construct(
		*
		* @return ResponseInterface


		### Changed

		- [BC Break] `HttpClient::sendRequest(RequestInterface $request)` has a return type annotation. The mew

Adding PSR package #128

Adding PSR package #128

Uh oh!

Conversation

Nyholm commented Aug 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nyholm commented Jul 29, 2018

Uh oh!

Nyholm commented Jul 29, 2018

Uh oh!

dbu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nyholm commented Jul 30, 2018

Uh oh!

dbu left a comment

Choose a reason for hiding this comment

Uh oh!

sagikazarmark commented Jul 30, 2018

Uh oh!

Nyholm commented Jul 30, 2018

Uh oh!

Nyholm commented Jul 30, 2018

Uh oh!

Uh oh!

Nyholm commented Aug 18, 2017 •

edited

Loading