Skip to content
This repository was archived by the owner on Jan 6, 2024. It is now read-only.

Conversation

sagikazarmark
Copy link
Member

No description provided.

@sagikazarmark sagikazarmark added this to the v1.0.0 milestone Jan 26, 2016
CHANGELOG.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should actually not clutter the changelog with this. users of the library do not see any effect of that change, its only used when installing the lib for development.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to mention I have to revert it because integration tests are using puli which is beta 😄

@sagikazarmark sagikazarmark force-pushed the stable_release branch 2 times, most recently from c60ba77 to 5056c3b Compare January 26, 2016 15:28
sagikazarmark added a commit that referenced this pull request Jan 26, 2016
@sagikazarmark sagikazarmark merged commit e884cf6 into master Jan 26, 2016
@sagikazarmark sagikazarmark deleted the stable_release branch January 26, 2016 20:39
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use 1.0-dev here. The reason is that commits after the first stable release will probably be bug fixes. So the following release will rather be 1.0.1 and not 1.1.0. The branch alias can then be updated when the first new feature was merged (which requires to bump the minor version).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, @dbu came with the same reason. I thought otherwise so far, but this is not something which I cared about too much, so probably you are right.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sagikazarmark for merging them all. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thinking about this again, i think the main argument for calling this 1.0 is that people can get their fixes by depending on 1.0.*@dev and play it safe with not ending up with new features of 1.1 that might have side effects for them.

@xabbuh xabbuh mentioned this pull request Jan 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants