Fix promise unwrapping in tutorial #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
reviewed
Jan 21, 2017
| @@ -119,8 +119,8 @@ Using the promise directly | |||
| If you don't want to use the callback system, you can also get the state of the promise with ``$promise->getState()`` | |||
| will return of one ``Promise::PENDING``, ``Promise::FULFILLED`` or ``Promise::REJECTED``. | |||
|
|
|||
| Then you can get the response of the promise if it's in ``FULFILLED`` state with ``$promise->getResponse()`` call or | |||
| get the error of the promise if it's in ``REJECTED`` state with ``$promise->getRequest()`` call | |||
| Then you can get the response of the promise if it's in ``FULFILLED`` state or get the error of the promise if it's in | |||
There was a problem hiding this comment.
do we return the exception or throw it? i would say exception not error, and if we throw say trigger instead of get
sagikazarmark
force-pushed
the
promise_fixes
branch
from
0c699a6 to
1b5c193
Compare
sagikazarmark
force-pushed
the
promise_fixes
branch
from
1b5c193 to
f73a36d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #171