Moved Symfony before Buzz #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jun 24, 2019
xabbuh
approved these changes
Jun 24, 2019
|
Should we update order on the HTTPlug adapters too? @dbu @sagikazarmark? |
|
I'm okay if we suggest a better maintained client. It only matters anyway if there are multiple ones installed. For the user it shouldn't really matter, they should rely on the interface. The only thing that would impact them is a client not adhering the standard or performance differences. Again, I think we can make the better choice for the user in those cases as well. |
|
Okey. Thank you for the input. I've updated the PR |
Taluu
approved these changes
Jun 27, 2019
|
Thank you for the reviews |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved Symfony before Buzz since it is fairly more used and maintained. Im not sure if this list should be ordered by popularity, performance, most likeable or random. But this feels better.