Fix the Mock strategy to work for async clients too #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
force-pushed
the
fix-mock-discovery
branch
from
8aab76c to
f6973e5
Compare
dbu
approved these changes
Feb 23, 2019
Contributor
dbu
left a comment
dbu
left a comment
There was a problem hiding this comment.
oh, was not aware we missed that! i will do a patch release with this, i consider it a bug. mock comes last, so i can't see this affecting production systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR makes the Mock client discoverable as an async client too.
Why?
I need it in getsentry/sentry-php#777 to avoid using a real client while testing the autodiscovery process.
Checklist