Fix PHPUnit6 issue #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've updated the PR now. This will work. Adding `printerClass="Http\Client\Tests\ResultPrinter" to phpunit.xml.dist will make sure this is class is used. |
|
should you add the thing about the custom result printer to the readme? and should we use it in the phpunit.xml.dist provided by this repo? |
|
I do not know. It is not a new feature. It is just adapted for PHPUnit 6. |
|
fair enough |
|
though providing some setup documentation in the README would not hurt if somebody builds their own adapter, or for us when we start a new adapter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #21
Is this a good solution? Im not sure how else we could do it. Any input is appreciated.