Skip to content

Fix implicit nullable type to avoid PHP 8.4 warnings #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Fix implicit nullable type to avoid PHP 8.4 warnings #247

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77c0b71
Fix implicit nullable type to avoid PHP 8.4 warnings
eiriksm Sep 23, 2024
12bd68f
Add 8.4 to matrix
eiriksm Sep 23, 2024
d6a4110
Update tests.yml
eiriksm Sep 23, 2024
bab3029
Merge branch 'php-http:2.x' into fix/nullable
eiriksm Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/HttpMethodsClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ final class HttpMethodsClient implements HttpMethodsClientInterface
/**
* @param RequestFactory|RequestFactoryInterface $requestFactory
*/
public function __construct(ClientInterface $httpClient, $requestFactory, StreamFactoryInterface $streamFactory = null)
public function __construct(ClientInterface $httpClient, $requestFactory, ?StreamFactoryInterface $streamFactory = null)
{
if (!$requestFactory instanceof RequestFactory && !$requestFactory instanceof RequestFactoryInterface) {
throw new \TypeError(
Expand Down