Skip to content

Cleanup #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2016
Merged

Cleanup #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,20 @@
# Change Log

## 1.0.0 - 2016-03-03

### Added

- New configuration for authentication plugin. You may now specify the authentication credentials directly in the bundle's configuration. This will break previous authentication configuration.
- Client factories for Curl, React and Socket.

### Fixed

- Bug with circular reference when a client was named 'default'

### Removed

- Dependency on `php-http/discovery`. You must now install `puli/symfony-bundle` to use auto discovery.

## 0.2.0 - 2016-02-23

## 0.1.0 - 2016-01-11
5 changes: 3 additions & 2 deletions ClientFactory/PluginClientFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,18 @@

namespace Http\HttplugBundle\ClientFactory;

use Http\Client\Plugin\Plugin;
use Http\Client\Plugin\PluginClient;

/**
* This factory creates a PluginClient.
*
* @author Tobias Nyholm <[email protected]>
*/
class PluginClientFactory
final class PluginClientFactory
{
/**
* @param array $plugins
* @param Plugin[] $plugins
* @param ClientFactory $factory
* @param array $config
*
Expand Down
3 changes: 1 addition & 2 deletions HttplugFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ public function find($type)
{
$class = $this->findOneByType($type);

// TODO: use doctrine instantiator?
return new $class();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not believe it is a good idea to instanciate a factory class without calling its constructor. Our DiactorosMessageFactory will not work unless its constructor is used.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, remove that comment

}

Expand Down Expand Up @@ -74,7 +73,7 @@ private function findOneByType($type)
}

/**
* Evaulates conditions to boolean.
* Evaluates conditions to boolean.
*
* @param mixed $condition
*
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# HttplugBundle
# HTTPlug Bundle

[![Latest Version](https://img.shields.io/github/release/php-http/HttplugBundle.svg?style=flat-square)](https://github.com/php-http/HttplugBundle/releases)
[![Software License](https://img.shields.io/badge/license-MIT-brightgreen.svg?style=flat-square)](LICENSE)
Expand All @@ -7,7 +7,7 @@
[![Quality Score](https://img.shields.io/scrutinizer/g/php-http/httplug-bundle.svg?style=flat-square)](https://scrutinizer-ci.com/g/php-http/HttplugBundle)
[![Total Downloads](https://img.shields.io/packagist/dt/php-http/httplug-bundle.svg?style=flat-square)](https://packagist.org/packages/php-http/HttplugBundle)

**Symfony integration for the [php-http Httplug](http://docs.httplug.io/) HTTP client**
**Symfony integration for [HTTPlug](http://httplug.io/).**


## Install
Expand Down