Cleanup #65
Merged
Cleanup #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,7 +37,6 @@ public function find($type) | |||
| { | |||
| $class = $this->findOneByType($type); | |||
|
|
|||
| // TODO: use doctrine instantiator? | |||
There was a problem hiding this comment.
I do not believe it is a good idea to instanciate a factory class without calling its constructor. Our DiactorosMessageFactory will not work unless its constructor is used.
There was a problem hiding this comment.
Agree, remove that comment
|
Added a few more things to #64 |
|
Added changelog |
|
👍 |
|
I added a few things as well. Can you please squash commits? Call it something like Prepare stable release. Thank you. |
|
Squashed! |
|
Thanks |
sagikazarmark
added a commit
that referenced
this pull request
Mar 3, 2016
Cleanup before stable release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will address some of the changes in #64