Skip to content

Added an sf4 example for enabling the bundle #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

gmponos
Copy link
Contributor

@gmponos gmponos commented Dec 27, 2019

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Documentation Yes
License MIT

What's in this PR?

Update the README file on how to register/enable the bundle.

TBH it might be preferable to point to an external resource.

@dbu
Copy link
Collaborator

dbu commented Dec 27, 2019

thanks. this is better than explaining the symfony 3 way.

we have https://php-http.readthedocs.io/en/latest/integrations/symfony-bundle.html which seems like the right external source. can you change the readme to only explain the flex way, and link to the documentation for the installation without flex? and do this PR against the documentation to explain the symfony 4/5 way of things?

@dbu
Copy link
Collaborator

dbu commented Jan 6, 2020

see #380 and php-http/documentation#275

@dbu dbu closed this Jan 6, 2020
@dbu
Copy link
Collaborator

dbu commented Jan 6, 2020

thanks for bringing this up @gmponos

@gmponos
Copy link
Contributor Author

gmponos commented Jan 6, 2020

arggg.. my mind always forgets things like documentations and stuff.. totally forgot to update this PR.

Anyway glad it helped in anyway...

@gmponos gmponos deleted the sf4-example branch January 6, 2020 10:31
@dbu
Copy link
Collaborator

dbu commented Jan 6, 2020

no worries, was quick to wrap it up, thanks for having realized it in the first place!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants