Skip to content

URLify header value links #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2019
Merged

URLify header value links #366

merged 1 commit into from
Dec 9, 2019

Conversation

ostrolucky
Copy link
Collaborator

Reference: #355 (comment)

Copy link
Collaborator

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@dbu dbu merged commit eb9e8a9 into php-http:master Dec 9, 2019
@ostrolucky
Copy link
Collaborator Author

Damit actually I forgot to test this with https and mistakenly used ?s instead of s?

@dbu
Copy link
Collaborator

dbu commented Dec 9, 2019

oops, also overlooked that one. at least it works if you do httpXs 😁

i guess adding automated tests for this is quite complicated, not sure its worth it.

@dbu
Copy link
Collaborator

dbu commented Dec 10, 2019

are you going to do a follow-up pull request to correct it?

@ostrolucky
Copy link
Collaborator Author

Yes, in couple days perhaps

@dbu
Copy link
Collaborator

dbu commented Dec 10, 2019

i made #368 - that is all we need, or am i missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants