Skip to content

Update docblocks with official documentation #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Update docblocks with official documentation #3

merged 1 commit into from
Oct 30, 2018

Conversation

shadowhand
Copy link
Collaborator

@shadowhand shadowhand commented Oct 26, 2018

Interface documentation was not updated after PSR-15 was approved, which makes these interfaces out of sync with the accepted specification.

Refs php-fig/http-server-handler#4
Refs php-fig/fig-standards#1107

@shadowhand
Copy link
Collaborator Author

If approved, this should be tagged as version 1.0.1.

Copy link
Member

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per php-fig/fig-standards#1107 (comment) too, I agree with this. 👍

@shadowhand
Copy link
Collaborator Author

shadowhand commented Oct 30, 2018

@Jean85 I need write on this repo too.

@Jean85
Copy link
Member

Jean85 commented Oct 30, 2018

@shadowhand done 👍

@shadowhand shadowhand merged commit 2296f45 into php-fig:master Oct 30, 2018
@shadowhand shadowhand deleted the fix/phpdoc-summary branch October 30, 2018 17:12
@shadowhand
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants