Update docblocks with official documentation #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If approved, this should be tagged as version |
Jean85
approved these changes
Oct 30, 2018
There was a problem hiding this comment.
Here too, LGTM 👍 in reference to php-fig/fig-standards#1107 (comment)
|
Ping me if you do not have permissions for merge/release. |
|
I'm not sure who has ownership over these repos. Maybe @weierophinney ? |
|
As editor yes, he has access. |
|
Um, @shadowhand is editor; I'm sponsor. 😄 I don't have write access to this repo, based on what GitHub is reporting to me currently... |
|
Woops sorry, I mixed those up. Well, the editor should retain access to the repos, even after approval; hence, I've given write access to @shadowhand |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interface documentation was not updated after PSR-15 was approved, which makes these interfaces out of sync with the accepted specification.
Refs php-fig/fig-standards#1107