Skip to content

Fix issue with null value in first price/first currency. #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix issue with null value in first price/first currency. #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/resources/liquibase/version/0.4.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,6 @@
<include file="0.4/2016-08-22--series_sales.xml" relativeToChangelogFile="true" />
<include file="0.4/2016-08-27--fix_series_sales_price.xml" relativeToChangelogFile="true" />
<include file="0.4/2016-09-28--add_creator_data_to_series_sales.xml" relativeToChangelogFile="true" />
<include file="0.4/2016-09-28--add_constraints_to_series-first-price.xml" relativeToChangelogFile="true" />

</databaseChangeLog>
20 changes: 20 additions & 0 deletions ...ain/resources/liquibase/version/0.4/2016-09-28--add_constraints_to_series-first-price.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<?xml version="1.0" encoding="UTF-8"?>
<databaseChangeLog
xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog
http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.0.xsd">

<changeSet id="add-not_null_constraints-to-first-price" author="cssru" context="scheme">

<addNotNullConstraint columnDataType="DECIMAL(19,2)"
columnName="first_price"
tableName="series_sales" />

<addNotNullConstraint columnDataType="VARCHAR(3)"
columnName="first_currency"
tableName="series_sales" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мне лень доделывать и тебя просить тоже не хочется. Но в следующий раз, когда будешь писать миграцию, старайся выстраивать атрибуты в некой логичной последовательности -- сначала название таблицы, а затем название колонки, а потом ее тип. Мелочь, конечно :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Логика отсюда: http://www.liquibase.org/documentation/changes/add_not_null_constraint.html


</changeSet>

</databaseChangeLog>