Fix issue with null value in first price/first currency. #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
php-coder
requested changes
Sep 30, 2016
| <changeSet id="add-not_null_constraints-to-first-price" author="cssru" context="scheme"> | ||
| <comment>Adds not null constraints to first_price and first_currency columns</comment> | ||
|
|
||
| <addNotNullConstraint columnDataType="CURRENCY" |
There was a problem hiding this comment.
We decided to not use CURRENCY pseudo-type because it doesn't work for us on MySQL. See #461
| http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.0.xsd"> | ||
|
|
||
| <changeSet id="add-not_null_constraints-to-first-price" author="cssru" context="scheme"> | ||
| <comment>Adds not null constraints to first_price and first_currency columns</comment> |
There was a problem hiding this comment.
I suggest to remove this comment.
cssru
force-pushed
the
gh467_transaction_null_price
branch
from
32ee115 to
ef2770c
Compare
php-coder
reviewed
Oct 10, 2016
|
|
||
| <addNotNullConstraint columnDataType="VARCHAR(3)" | ||
| columnName="first_currency" | ||
| tableName="series_sales" /> |
There was a problem hiding this comment.
Мне лень доделывать и тебя просить тоже не хочется. Но в следующий раз, когда будешь писать миграцию, старайся выстраивать атрибуты в некой логичной последовательности -- сначала название таблицы, а затем название колонки, а потом ее тип. Мелочь, конечно :)
There was a problem hiding this comment.
php-coder
approved these changes
Oct 10, 2016
php-coder
requested changes
Oct 10, 2016
cssru
force-pushed
the
gh467_transaction_null_price
branch
from
096678d to
7413819
Compare
cssru
force-pushed
the
gh467_transaction_null_price
branch
from
7413819 to
22d16c1
Compare
|
Конфликт разрулил, засквошил. |
|
Changes Unknown when pulling 22d16c1 on cssru:gh467_transaction_null_price into * on php-coder:master*. |
php-coder
approved these changes
Oct 10, 2016
|
Merged in d864d2d commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed to #467