Facilitate adding static files (without having to rewrite router/endpoint) #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you very much for the awesome project.
I wanted to add some static files to the Phoenix server (my original goal was to include JPEG and PNG images). After trying for a while, I realised I would need to copy a lot of code and basically recreate what
PhoenixPlayground.Router.LiveRouteralready does, instead of just using it.I was wondering if the project would be open to this PR, whose main intention is to simplify how static files can be added. While working on it, I noticed that using
:plugand:livetogether did not behave as expected. So, I’m proposing changes toPhoenixPlayground.Routerto allow both options to be passed and work in tandem.I hope this change is useful to the project. Please let me know your thoughts.