-
Notifications
You must be signed in to change notification settings - Fork 39
Closed
Description
First, thank you @philipstanislaus for building this nice and helpful tool!
I ran in some issues while trying to use it on a project, which I could track down to these points:
- Items are ignored, if their
parentIdisundefined. - Items are ignored, if their
parentIdis0.
Looking at the code, I saw, that you expect IDs to be strings. My project uses Integers with parentId: 0 for Root-Items. So no surprise it didn’t work out.
Would you mind:
- adding support for Integer IDs?
- allowing
undefined(= nonexisting) and0(Int) as values of parentId in addition tonull?
I would submit a PR, but I’m not used programming in TypeScript. :) Thank you in advance.
Metadata
Metadata
Assignees
Labels
No labels