Added a way to filter proxies by protocol + fixed PremProxy provider #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proxies can now be filtered with an optional parameter in the RequestProxy constructor. For this the parsers have to set the protocol for each proxy object they build. Protocols are stored in the ProxyObject.Protocol enum. PremProxy: parsing was broken because the port number was 'encrypted' and no longer stored in CSS. They are now obtained from a javascript file that holds a function to the key-port pairs.
Owner
|
Thanks for the PR @la55u ! |
Merged
Owner
|
Thanks for the PR @la55u ! It would be great to have the protocol filter you introduced as part of the command line arguments as well in the future! Marked as #48 Thanks again for contributing! |
Contributor
Author
|
Cool, thanks for the fixes I was really lost with these tests... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxies can now be filtered with an optional parameter in the RequestProxy constructor. For this the parsers have to set the supported protocols for each proxy object they build. Protocols are stored in the ProxyObject.Protocol enum. Currently only FreeProxy parser supports HTTPS, but i'll add sslproxies dot org later as well.
PremProxy: parsing was broken because the port number was 'encrypted' and no longer stored in CSS.
They are now obtained from a javascript file that holds a function to the key-port pairs.
Let me know if I missed anything or something is wrong.