Skip to content

Conversation

@minrk
Copy link
Contributor

@minrk minrk commented Apr 28, 2017

When the FD is not valid.

Technically, I think the same is possible for all std streams.

When this is the case, the block raises an AttributeError, which was not among the caught exceptions.

cf jupyterhub/jupyterhub#1108

raising an AttributeError, which was not among the caught exceptions
@minrk
Copy link
Contributor Author

minrk commented Apr 28, 2017

This could also have been fixed by adding AttributeError to the exception list on L70. I figured that wouldn't be desirable since it would catch AttributeErrors due to potential future typos elsewhere, as well.

@takluyver
Copy link
Member

Thanks Min, this looks reasonable to me. I'll give it a day or two in case @jquast or @MountainRider want to have a look.

@MountainRider
Copy link

I don't see any problems with this change.

@takluyver takluyver merged commit a8bf138 into pexpect:master Jul 28, 2017
@jcrist jcrist mentioned this pull request Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants