Fix Transaction Tag #313
Merged
Fix Transaction Tag #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Smart Contract SDK
a-urth
approved these changes
Oct 29, 2019
added 2 commits
October 30, 2019 22:38
…tible with the previous contracts.
…op in the Smart Contract SDK" This reverts commit a4e898d.
|
I've reversed the new wasms since the Transaction Tag values remains same as before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Transaction Tag value in the Wavelet's Himitsu is different than in the Smart Contract SDK because of the removal of Nop tag. The Smart Contract SDK still contains Nop tag.
Because of the Transaction Tag value is an incrementing number, this is causing it to have different meaning.
All the smart contracts need to be recompiled with the updated Smart Contract SDK.
This PR updates the wasm by recompiling the wasm with the updated Smart Contract SDK.
PR to update the Smart Contract SDK:
perlin-network/smart-contract-rs#9