PMM-7 Rpmbuild maintenance #4703
Open
+6
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #4703 +/- ##
=======================================
Coverage 45.67% 45.67%
=======================================
Files 363 363
Lines 37654 37654
=======================================
Hits 17197 17197
Misses 18797 18797
Partials 1660 1660
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ademidoff
commented
Oct 25, 2025
|
|
||
| RUN dnf update -y && \ | ||
| dnf install -y crypto-policies-scripts && \ | ||
| update-crypto-policies --set DEFAULT:SHA1 && \ |
There was a problem hiding this comment.
This was necessary at the time when we had NodeJS 18.x onboard, so it's redundant now.
ademidoff
requested review from
JiriCtvrtka and
idoqo
and removed request for
a team
idoqo
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-7
This pull request updates the Go toolchain version and simplifies the Docker build configuration for RPM builds. The main changes include upgrading to Go 1.24.7, removing unnecessary crypto policy configuration steps, and cleaning up environment variable usage in Dockerfiles.
Go toolchain version update:
go.modand all relevant Dockerfiles to ensure the use of the latest bug fixes and security patches. [1] [2] [3] [4]Dockerfile simplifications:
crypto-policies-scriptsand related SHA1 policy steps fromDockerfile.el8,Dockerfile.el9, andDockerfile.hetzner-el9, streamlining the build process. [1] [2] [3]FLAVORandOSvariables in all Dockerfiles, leaving onlyDISTfor clarity. [1] [2] [3]