Skip to content

Conversation

VincentLanglet
Copy link
Collaborator

@VincentLanglet VincentLanglet commented Apr 16, 2020

Close #116

I recommend to make a v0.11, since this is a BC-break

I allow both

private function callThrowLogic(): void
{
    $this->throwLogic();
}

And

/**
 * @throws LogicException
 */
private function throwLogic(): void
{
    throw new LogicException();
}

So the ignoreDescriptiveUncheckedExceptions is useless now ; I removed it.

@VincentLanglet VincentLanglet mentioned this pull request Apr 28, 2020
@VincentLanglet
Copy link
Collaborator Author

Hi @pepakriz Do you have time to look at my PR ? Do you need some help ?

@pepakriz
Copy link
Owner

Hi @VincentLanglet . I've opened v0.11 and going to merge this. Thank you!

@pepakriz pepakriz merged commit 043cea2 into pepakriz:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unfixable scenario with reportUnusedCatchesOfUncheckedExceptions / [Breaking change request ?] Unchecked exception
2 participants