Skip to content

Conversation

Daniel-Cortez
Copy link
Contributor

@Daniel-Cortez Daniel-Cortez commented Jun 22, 2020

What this PR does / why we need it:

Restricts local constants to the scope of the compound block they were defined in, instead of the scope of the whole function, in order to fix the bug described in #541.

Which issue(s) this PR fixes:

Fixes #541

What kind of pull this is:

  • A Bug Fix
  • A New Feature
  • Some repository meta (documentation, etc)
  • Other

Additional Documentation:

@Daniel-Cortez Daniel-Cortez requested a review from a team as a code owner June 22, 2020 14:51
@YashasSamaga YashasSamaga linked an issue Jun 22, 2020 that may be closed by this pull request
@Y-Less Y-Less closed this Sep 19, 2020
@Y-Less Y-Less changed the title Restrict local constants to the local block they're defined in [MERGED] Restrict local constants to the local block they're defined in Sep 20, 2020
@Daniel-Cortez Daniel-Cortez deleted the fix-541 branch October 19, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Local constants don't go out of scope until the end of function

2 participants