Using 'pattern' in url causes 404s

[jkbyln]

I set this up under a url like:
dev.url.com/patterns/

After generating a site under public and uploading it to my server, I was getting 404's on patterns when I click into one from the top navigation bar.

Turns out postmessage.js has a regex of

/patterns\/(.*)$/

defined on line 91, which was giving me issues because my url already contained the string 'patterns'.

Minor issue, but it would be nice if it matched something less generic, or took the possibility of /patterns/patterns/ into account.

[bmuenzenmeyer]

Hi @jkbyln thanks for reporting this - I will try to take a look at it this weekend but am up against some deadlines.

[bmuenzenmeyer]

The pathing and fluid naming convention logic should be more robust - I believe this is something Dave has really striven for with PL v2

[jkbyln]

No problem! If I find a solution to this should I submit a pull request to patternlab-node or to patternlab-php?

[bmuenzenmeyer]

@jkbyln most likely patternlab-node

[scottnath]

@jkbyln I just ran into this too with a git repo with 'patterns' in the name causing out gh-pages version of the site to not work. Have you found the solution yet?

@bmuenzenmeyer has a solution for this been put into PL v2?

thanks!
scott

[bmuenzenmeyer]

I'd like to see a solution to this for PL node v1.0.

I am in the middle of some major reworking for v0.10 and then will attempt
to incorporate this bug fix soon after. Looking at this closer, this sounds
like an issue with the client frontend meaning it probably does apply to
pattern lab PHP as well. I will make sure to check that project too.

Either way, thanks for the continued support and interest in pattern lab
node!
On Fri, Jul 24, 2015 at 2:05 PM Scott Nath notifications@github.com wrote:

@jkbyln https://github.com/jkbyln I just ran into this too with a git
repo with 'patterns' in the name causing out gh-pages version of the site
to not work. Have you found the solution yet?

@bmuenzenmeyer https://github.com/bmuenzenmeyer has a solution for this
been put into PL v2?

thanks!
scott

—
Reply to this email directly or view it on GitHub
#125 (comment)
.

[bmuenzenmeyer]

I'll stretch for this in v0.10.0 since it's causing angst for folks