Skip to content

Conversation

@geel9
Copy link

@geel9 geel9 commented Feb 29, 2024

This PR adds support for the largeBlob extension.

@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 74.27%. Comparing base (9ad038b) to head (ccd666a).

Files Patch % Lines
...Objects/AuthenticationExtensionsLargeBlobInputs.cs 0.00% 3 Missing ⚠️
...bjects/AuthenticationExtensionsLargeBlobOutputs.cs 0.00% 3 Missing ⚠️
...ls/Objects/AuthenticationExtensionsClientInputs.cs 0.00% 1 Missing ⚠️
...s/Objects/AuthenticationExtensionsClientOutputs.cs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #508      +/-   ##
==========================================
- Coverage   74.49%   74.27%   -0.23%     
==========================================
  Files          98      100       +2     
  Lines        2639     2647       +8     
  Branches      445      445              
==========================================
  Hits         1966     1966              
- Misses        570      578       +8     
  Partials      103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this contribution

@abergs abergs merged commit c7d64cc into passwordless-lib:master Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants