Skip to content

Conversation

@nitisht
Copy link
Member

@nitisht nitisht commented Dec 11, 2023

Fixes #564.

Description

Add support for multiple column names placeholders in the message field
of an alert. This is useful to set more useful alert messages for the targets.


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht requested review from theteachr and trueleo December 11, 2023 03:56
Simplify by directly returning a `Vec` instead of an `Option`.
@nitisht nitisht merged commit 40cddb5 into parseablehq:main Dec 11, 2023
@nitisht nitisht deleted the message-format branch December 11, 2023 07:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Message format feature not replacing placeholders with correct value

3 participants