Add LLM related actions to roles

[parmesant]

Fixes #XXXX.

Description

---

This PR has:

• been tested to ensure log ingestion and log query works.
• added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
• added documentation for new or modified features or behaviors.

Summary by CodeRabbit

• New Features
  • Expanded permissions for Editor, Writer, and Reader roles to include the ability to add and delete LLMs.

[coderabbitai]

Walkthrough

The change updates the default permission builders for the Editor, Writer, and Reader roles by adding the AddLLM and DeleteLLM actions to their respective allowed actions lists. This expands the set of permissions granted to these roles, specifically enabling LLM-related operations.

Changes

File(s)	Change Summary
src/rbac/role.rs	Updated permission builders for Editor, Writer, and Reader roles to include AddLLM and DeleteLLM actions in their allowed action vectors.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Role
    participant RBAC

    User->Role: Request permission for AddLLM/DeleteLLM
    Role->RBAC: Check if action is in allowed actions
    RBAC-->Role: Return permission status (now includes AddLLM/DeleteLLM)
    Role-->User: Grant or deny permission

Loading

Possibly related PRs

• LLM related actions #1287: Originally introduced the AddLLM and DeleteLLM actions into the Action enum and integrated them into the permission-building logic, making this PR a direct continuation or refinement.

Suggested reviewers

• nikhilsinhaparseable

Poem

In the meadow of code, permissions did grow,
New actions for LLMs now join the show.
Editors, Writers, and Readers delight,
With Add and Delete, their powers take flight.
Hopping through roles with a carrot in hand,
The rabbit approves—let permissions expand! 🥕

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 81769b5 and b564b1c.

📒 Files selected for processing (1)

• src/rbac/role.rs (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (10)

• GitHub Check: Build Default x86_64-pc-windows-msvc
• GitHub Check: Build Default aarch64-apple-darwin
• GitHub Check: Build Kafka aarch64-apple-darwin
• GitHub Check: Build Default x86_64-apple-darwin
• GitHub Check: Build Kafka x86_64-unknown-linux-gnu
• GitHub Check: Build Default aarch64-unknown-linux-gnu
• GitHub Check: Quest Smoke and Load Tests for Standalone deployments
• GitHub Check: Build Default x86_64-unknown-linux-gnu
• GitHub Check: coverage
• GitHub Check: Quest Smoke and Load Tests for Distributed deployments

🔇 Additional comments (3)

src/rbac/role.rs (3)

247-248: LGTM: LLM actions addition to Editor role

Adding AddLLM and DeleteLLM actions to the Editor role is consistent with the existing permission model, as editors already have access to other LLM operations (QueryLLM, GetLLM, ListLLM) and have extensive permissions for managing various resources.

---

293-294: LGTM: LLM actions addition to Writer role

Adding AddLLM and DeleteLLM actions to the Writer role is consistent with the existing permissions, as writers already have access to other LLM operations and can perform similar management actions on other resources like alerts and correlations.

---

319-320: Verify permissions for Reader role

Adding AddLLM and DeleteLLM actions to the Reader role seems inconsistent with the principle of least privilege. Readers typically have more restricted, primarily read-only permissions. Providing destructive capabilities like DeleteLLM to readers represents a significant expansion of their privileges.

Please verify that this is the intended permission model for readers. Consider whether readers should have the ability to add and delete LLM resources or if these permissions should be limited to roles with higher privileges.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.