fix: staging files count in metrics #1207

nikhilsinhaparseable · 2025-02-24T12:42:00Z

current - we find group of arrow files and a parquet file
in order to merge all arrow files in a group and write to parquet in disk in metrics,
we set count of arrow files for 1 group not all

change - we get sum of total count of arrow files from all the groups then set this sum in metrics

Fixes #1149

Summary by CodeRabbit

New Features
- Aggregated file metrics now provide a consolidated view of the total number of staging files and their cumulative size, streamlining monitoring and reporting.
Refactor
- Updated logging for synchronization events now uses more visible information-level messages, enhancing clarity during process tracking.

current - we find group of arrow files and a parquet file in order to merge all arrow files in a group and write to parquet in disk in metrics, we set count of arrow files for 1 group not all change - we get sum of total count of arrow files from all the groups then set this sum in metrics fixes: parseablehq#1149

coderabbitai · 2025-02-24T12:42:10Z

Walkthrough

The changes modify the metrics reporting for Arrow files and adjust logging levels. In src/parseable/streams.rs, the code now aggregates metrics by computing the total number and cumulative size of Arrow files in the staging directory instead of reporting metrics for each individual file. In src/storage/object_storage.rs, the log level for the synchronization process has been changed from debug to info, and the related imports have been updated accordingly.

Changes

File(s)	Change Summary
src/parseable/streams.rs	Added aggregated metrics for Arrow files by calculating total count and total sizes; removed individual file metric reporting.
src/storage/object_storage.rs	Changed logging in `upload_files_from_staging` from debug to info; updated import statements to reflect the logging level change.

Sequence Diagram(s)

sequenceDiagram
    participant StreamProcessor
    participant FileSystem
    participant MetricsService
    StreamProcessor->>FileSystem: Retrieve staging_files list and metadata
    FileSystem-->>StreamProcessor: Return list of Arrow files with sizes
    StreamProcessor->>MetricsService: Set 'total_arrow_files' metric (file count)
    StreamProcessor->>MetricsService: Set 'total_arrow_files_size' metric (total size)

sequenceDiagram
    participant ObjectStorage
    participant Logger
    ObjectStorage->>Logger: Log info "Starting object_store_sync for stream"
    Logger-->>ObjectStorage: Record info log entry

Poem

I'm a coding rabbit, hopping through the code,
With metrics stacked and logs reloaded.
Arrow files counted in a joyful array,
Info logs chime in a bright new way.
Hop along with bytes and cheer each change,
Celebrating our code’s rhythm across every range! 🐇💻

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 245ec54 and 701f050.

📒 Files selected for processing (2)

src/parseable/streams.rs (2 hunks)
src/storage/object_storage.rs (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (10)

GitHub Check: Build Default x86_64-pc-windows-msvc
GitHub Check: Build Default aarch64-apple-darwin
GitHub Check: Build Default x86_64-apple-darwin
GitHub Check: Build Default aarch64-unknown-linux-gnu
GitHub Check: Quest Smoke and Load Tests for Standalone deployments
GitHub Check: Build Kafka aarch64-apple-darwin
GitHub Check: Quest Smoke and Load Tests for Distributed deployments
GitHub Check: Build Default x86_64-unknown-linux-gnu
GitHub Check: Build Kafka x86_64-unknown-linux-gnu
GitHub Check: coverage

🔇 Additional comments (3)

src/parseable/streams.rs (2)

447-465: LGTM! The metrics calculation is now correctly implemented.

The changes properly aggregate the total number and size of arrow files across all groups, fixing the previous issue where metrics were only considering individual groups. The implementation is efficient, using functional operations like map and sum.

504-515: LGTM! Proper metrics cleanup during file deletion.

The code correctly updates the storage size metrics when arrow files are deleted, maintaining consistency with the new aggregation approach. The error handling for file deletion is robust, with appropriate process abort on critical failures.

src/storage/object_storage.rs (1)

722-722: LGTM! Appropriate log level for object store sync.

Changing the log level from debug to info is appropriate as object store synchronization is a significant operation that should be visible in standard logging output.

✨ Finishing Touches

📝 Generate Docstrings (Beta)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

current - we find group of arrow files and a parquet file in order to merge all arrow files in a group and write to parquet in disk in metrics, we set count of arrow files for 1 group not all change - we get sum of total count of arrow files from all the groups then set this sum in metrics fixes: parseablehq#1149

coderabbitai bot approved these changes Feb 24, 2025

View reviewed changes

de-sh approved these changes Feb 25, 2025

View reviewed changes

nitisht merged commit 505c314 into parseablehq:main Feb 25, 2025
14 checks passed

coderabbitai bot mentioned this pull request Feb 25, 2025

fix: ensure panic safety #1212

Merged

3 tasks

coderabbitai bot mentioned this pull request Mar 14, 2025

fix: ensure current slot data goes into current slot file and isn't flushed until end of the slot #1238

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: staging files count in metrics #1207

fix: staging files count in metrics #1207

nikhilsinhaparseable commented Feb 24, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 24, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

fix: staging files count in metrics #1207

fix: staging files count in metrics #1207

Conversation

nikhilsinhaparseable commented Feb 24, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Feb 24, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

nikhilsinhaparseable commented Feb 24, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 24, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)