Skip to content

Conversation

nikhilsinhaparseable
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable commented Feb 18, 2025

flatten otel traces for empty Events or Links object in span

Summary by CodeRabbit

  • Refactor
    • Streamlined telemetry data processing to directly initialize records when no previous data exists, reducing unnecessary operations and enhancing overall efficiency.

flatten otel traces for empty `Events` or `Links` object in span
Copy link
Contributor

coderabbitai bot commented Feb 18, 2025

Walkthrough

The changes modify the logic within the flatten_span_record function in src/otel/traces.rs. The function now checks if the span records list is empty before deciding how to incorporate a new span record. If empty, the new record is directly assigned; if not, the new record is merged with each existing record. The function signature remains unchanged.

Changes

File(s) Summary
src/otel/…/traces.rs Updated flatten_span_record: added a conditional check to initialize the span records when empty and retained merging logic when spans already exist.

Sequence Diagram(s)

sequenceDiagram
    participant F as flatten_span_record
    participant R as span_records_json
    participant S as span_record_json

    F->>R: Check if span_records_json is empty?
    alt Empty
        F->>S: Initialize span_records_json with span_record_json
    else Not Empty
        F->>R: Merge span_record_json into each existing span
    end
    F-->>F: Return updated span_records_json
Loading

Poem

I’m a rabbit with a coding beat,
Hopping through logic, light and neat.
I check if spans are few or many,
Merging only when the list is uncanny!
With floppy ears and ASCII cheer,
My code now sings, sincere and clear.
🐰✨ Happy hops to a smoother year!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b4e7945 and 0b54f71.

📒 Files selected for processing (1)
  • src/otel/traces.rs (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/otel/traces.rs

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot previously approved these changes Feb 18, 2025
@nitisht nitisht requested a review from de-sh February 18, 2025 14:15
Signed-off-by: Nikhil Sinha <[email protected]>
coderabbitai[bot]
coderabbitai bot previously approved these changes Feb 18, 2025
nitisht
nitisht previously approved these changes Feb 18, 2025
Copy link
Contributor

@de-sh de-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests to better document the expectations we wish to be fulfilled by this code

@nitisht nitisht merged commit 671abae into parseablehq:main Feb 19, 2025
14 checks passed
parmesant pushed a commit to parmesant/parseable that referenced this pull request Feb 19, 2025
flatten otel traces for empty `Events` or `Links` object in span
---------

Signed-off-by: Nikhil Sinha <[email protected]>
@nikhilsinhaparseable nikhilsinhaparseable deleted the otel-traces-flattening-fix branch July 12, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants