-
-
Notifications
You must be signed in to change notification settings - Fork 149
fix: otel traces flattening fix #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: otel traces flattening fix #1196
Conversation
flatten otel traces for empty `Events` or `Links` object in span
WalkthroughThe changes modify the logic within the Changes
Sequence Diagram(s)sequenceDiagram
participant F as flatten_span_record
participant R as span_records_json
participant S as span_record_json
F->>R: Check if span_records_json is empty?
alt Empty
F->>S: Initialize span_records_json with span_record_json
else Not Empty
F->>R: Merge span_record_json into each existing span
end
F-->>F: Return updated span_records_json
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Signed-off-by: Nikhil Sinha <[email protected]>
0b54f71
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add tests to better document the expectations we wish to be fulfilled by this code
flatten otel traces for empty `Events` or `Links` object in span --------- Signed-off-by: Nikhil Sinha <[email protected]>
flatten otel traces for empty
Events
orLinks
object in spanSummary by CodeRabbit