Skip to content

regression: dataloss as a result of prematurely "finish"ed arrows #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
de-sh opened this issue Mar 14, 2025 · 1 comment · Fixed by #1238
Closed

regression: dataloss as a result of prematurely "finish"ed arrows #1240

de-sh opened this issue Mar 14, 2025 · 1 comment · Fixed by #1238
Assignees
@de-sh
Labels
bug

Comments

@de-sh
Copy link
Contributor

de-sh commented Mar 14, 2025 •
edited by nitisht
Loading

This is a regression happening after #1129 was merged.

Report: https://gist.github.com/de-sh/6648759b53bce7a7e21efd3319e100bb

ref: test that showcases this effect in practice

Possible Fix

Make flush intelligent enough to choose not to finish arrow from the current minute-slot.
@de-sh de-sh added the bug label Mar 14, 2025
@de-sh
Copy link
Contributor Author

de-sh commented Mar 14, 2025

The fix has been worked on and will be introduced as a PR post merging of #1238

de-sh/parseable@disk-writer...de-sh:parseable:is_current

@de-sh de-sh self-assigned this Mar 14, 2025
@nitisht nitisht changed the title bug: dataloss as a result of prematurely "finish"ed arrows regression: dataloss as a result of prematurely "finish"ed arrows Mar 15, 2025
@nitisht nitisht mentioned this issue Mar 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@de-sh de-sh

Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@de-sh