Skip to content

feat: Allow Parse.Object pointers in Cloud Code arguments #8490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 25, 2023
Merged

feat: Allow Parse.Object pointers in Cloud Code arguments #8490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
78c67d4
fix: remove username from verification emails
dblythy Mar 30, 2023
407825d
tests
dblythy Mar 30, 2023
0c49a4a
feat: allow Pointers in cloud code params
dblythy Mar 30, 2023
c38a4a9
Revert "tests"
dblythy Mar 30, 2023
80ab7b9
Revert "fix: remove username from verification emails"
dblythy Mar 30, 2023
a7c6375
Merge branch 'alpha' into allow-pointers
mtrezza May 21, 2023
8b1d7e7
Merge branch 'alpha' into allow-pointers
dblythy May 22, 2023
a178883
Merge branch 'alpha' into allow-pointers
mtrezza May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions spec/CloudCode.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1352,6 +1352,27 @@ describe('Cloud Code', () => {
});
});

it('allow cloud to encode Parse Objects', async () => {
const user = new Parse.User();
user.setUsername('username');
user.setPassword('password');
user.set('deleted', false);
await user.signUp();
Parse.Cloud.define(
'deleteAccount',
async req => {
expect(req.params.object instanceof Parse.Object).toBeTrue();
req.params.object.set('deleted', true);
await req.params.object.save(null, { useMasterKey: true });
return 'Object deleted';
},
{
requireMaster: true,
}
);
await Parse.Cloud.run('deleteAccount', { object: user.toPointer() }, { useMasterKey: true });
});

it('beforeSave should not affect fetched pointers', done => {
Parse.Cloud.beforeSave('BeforeSaveUnchanged', () => {});

Expand Down
6 changes: 6 additions & 0 deletions src/Routers/FunctionsRouter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ function parseObject(obj) {
return Object.assign(new Date(obj.iso), obj);
} else if (obj && obj.__type == 'File') {
return Parse.File.fromJSON(obj);
} else if (obj && obj.__type == 'Pointer') {
return Parse.Object.fromJSON({
__type: 'Pointer',
className: obj.className,
objectId: obj.objectId,
});
} else if (obj && typeof obj === 'object') {
return parseParams(obj);
} else {
Expand Down