Skip to content

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Jan 5, 2023

Fixes security vulnerability GHSA-vm5r-c87r-pf6x.

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: release 5 pf6x fix: Release 5 pf6x Jan 5, 2023
@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 5, 2023

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

@mtrezza mtrezza changed the base branch from alpha to release-5.x.x January 5, 2023 11:18
@mtrezza mtrezza closed this Jan 5, 2023
@mtrezza mtrezza reopened this Jan 5, 2023
@mtrezza mtrezza closed this Jan 5, 2023
@mtrezza mtrezza reopened this Jan 5, 2023
@mtrezza mtrezza closed this Jan 5, 2023
@mtrezza mtrezza reopened this Jan 5, 2023
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 94.12% // Head: 94.12% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (f2f3b46) compared to base (c8bc200).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                @@
##           release-5.x.x    #8369      +/-   ##
=================================================
- Coverage          94.12%   94.12%   -0.01%     
=================================================
  Files                182      182              
  Lines              13785    13779       -6     
=================================================
- Hits               12975    12969       -6     
  Misses               810      810              
Impacted Files Coverage Δ
src/Options/Definitions.js 100.00% <ø> (ø)
src/Options/index.js 100.00% <ø> (ø)
src/ParseServer.js 90.37% <100.00%> (+0.10%) ⬆️
src/middlewares.js 96.83% <100.00%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza mtrezza changed the title fix: Release 5 pf6x fix: The client IP address may be determined incorrectly in some cases Jan 5, 2023
@mtrezza mtrezza merged commit e016d81 into parse-community:release-5.x.x Jan 5, 2023
@mtrezza mtrezza deleted the fix-release-5-pf6x branch January 5, 2023 13:23
parseplatformorg pushed a commit that referenced this pull request Jan 31, 2023
## [5.4.1](5.4.0...5.4.1) (2023-01-31)

### Bug Fixes

* The client IP address may be determined incorrectly in some cases; it is now required to set the Parse Server option `trustProxy` accordingly if Parse Server runs behind a proxy server, see the express framework's [trust proxy](https://expressjs.com/en/guide/behind-proxies.html) setting; this fixes a security vulnerability in which the Parse Server option `masterKeyIps` may be circumvented, see [GHSA-vm5r-c87r-pf6x](GHSA-vm5r-c87r-pf6x) ([#8369](#8369)) ([e016d81](e016d81))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.1

@parseplatformorg parseplatformorg added the state:released-5.x.x Released as LTS version label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released-5.x.x Released as LTS version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants